linux-kernel - Re: [PATCH v2 1/1] thermal: intel Quark SoC X1000 DTS thermal driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfLj5moAXsbXz4bFh8Ukgv9+4DWYc63E_SOKckR+gqNeQ@mail.gmail.com>
Date:	Thu, 5 Mar 2015 18:11:28 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	"Ong, Boon Leong" <boon.leong.ong@...el.com>
Cc:	"Bryan O'Donoghue" <pure.logic@...us-software.ie>,
	"Zhang, Rui" <rui.zhang@...el.com>,
	"edubezval@...il.com" <edubezval@...il.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] thermal: intel Quark SoC X1000 DTS thermal driver

On Tue, Mar 3, 2015 at 3:13 AM, Ong, Boon Leong
<boon.leong.ong@...el.com> wrote:
>>> +config INTEL_QUARK_DTS_THERMAL
>>> +    tristate "Intel Quark DTS thermal driver"
>>> +    depends on X86 && IOSF_MBI
>>
>>Since the change is in RC-1 suggest
>>depends on X86_INTEL_QUARK
>>you can skip this though it's not important.
> Ya. That is true now since the below commit has been merged:
> 8bbc2a135b63bee6b41fa90f415521a97995a49f to mainline in 4.0-rc1
>
> On another thought, how about adding INTEL_QUARK_DTS_THERMAL to
> be selected by X86_INTEL_QUARK  in arch/x86/Kconfig ... and we can
> drop the above dependencies from here.

This driver as far as I understand is not critical to run Intel Quark.
So, there is should not be a dependency in the platform definition.

On the other hand is the driver will work exclusively on Quark? If so,
better to leave the mentioned dependency, .i.e.
depends on X86_INTEL_QUARK

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/