linux-kernel - RE: [PATCH v2 1/1] thermal: intel Quark SoC X1000 DTS thermal driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Mar 2015 16:19:13 +0000
From:	"Ong, Boon Leong" <boon.leong.ong@...el.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
CC:	Bryan O'Donoghue <pure.logic@...us-software.ie>,
	"Zhang, Rui" <rui.zhang@...el.com>,
	"edubezval@...il.com" <edubezval@...il.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/1] thermal: intel Quark SoC X1000 DTS thermal driver

>-----Original Message-----
>From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
>Sent: Friday, March 6, 2015 12:11 AM
>To: Ong, Boon Leong
>Cc: Bryan O'Donoghue; Zhang, Rui; edubezval@...il.com; Kweh, Hock Leong;
>linux-pm@...r.kernel.org; linux-kernel@...r.kernel.org
>Subject: Re: [PATCH v2 1/1] thermal: intel Quark SoC X1000 DTS thermal driver
>
>On Tue, Mar 3, 2015 at 3:13 AM, Ong, Boon Leong
><boon.leong.ong@...el.com> wrote:
>>>> +config INTEL_QUARK_DTS_THERMAL
>>>> +    tristate "Intel Quark DTS thermal driver"
>>>> +    depends on X86 && IOSF_MBI
>>>
>>>Since the change is in RC-1 suggest
>>>depends on X86_INTEL_QUARK
>>>you can skip this though it's not important.
>> Ya. That is true now since the below commit has been merged:
>> 8bbc2a135b63bee6b41fa90f415521a97995a49f to mainline in 4.0-rc1
>>
>> On another thought, how about adding INTEL_QUARK_DTS_THERMAL to
>> be selected by X86_INTEL_QUARK  in arch/x86/Kconfig ... and we can
>> drop the above dependencies from here.
>
>This driver as far as I understand is not critical to run Intel Quark.
>So, there is should not be a dependency in the platform definition.
Yup, Quark platform can boot up without this driver selected by default.

>
>On the other hand is the driver will work exclusively on Quark? If so,
>better to leave the mentioned dependency, .i.e.
>depends on X86_INTEL_QUARK
Yup. Currently, it is exclusive to Quark. 
In v3, I make it depends on X86_INTEL_QUARK only.