linux-kernel - Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54FB38F8.1080600@lwfinger.net>
Date:	Sat, 07 Mar 2015 11:44:24 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	54FB3523.7060600@...inger.net
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

On 03/07/2015 11:35 AM, Matteo Semenzato wrote:
> Il giorno sab, 07/03/2015 alle 11.28 -0600, Larry Finger ha scritto:
>> Have you actually tested this patch, or did you find this with some static checker?
>>
>> Larry
> The double unlock was found using smatch.

Are you really willing to test changes in locking based on a static checker? I 
would not be so quick.

By the way, my reading of the documentation is that up releases the lock whereas 
down sets it.  Thus, I think your patch introduces a bug rather than fix one. I 
agree that there is a mismatch, but I do not think your patch fixes anything.

Until this is actually tested on running code, NACK.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/