linux-kernel - Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309091618.GA10964@mwanda>
Date:	Mon, 9 Mar 2015 12:16:18 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Matteo Semenzato <mattew8898@...il.com>
Cc:	gregkh@...uxfoundation.org, navin.patidar@...il.com,
	oat.elena@...il.com, Larry.Finger@...inger.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

Why is it a RESEND?

RESEND is a bit rude because it implies that we messed up by ignoring
your first email so you're sending us the exact same thing again.
Sometimes rudeness is valid if people are ignoring good patches but you
send the first email 4 minutes before sending the second email.

On Sat, Mar 07, 2015 at 04:33:27PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@...il.com>

No need for this, we can get it from your email.

> 
> The rtw_cmd_thread semaphore was being unlocked twice.

This patch is probably correct, but it's a bit risky without testing or
further analysis.  Please explain how you verified that it won't cause
a deadlock.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/