linux-kernel - Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150307002447.GE993@katana>
Date:	Sat, 7 Mar 2015 01:24:48 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Cc:	"christian.ruppert@...tech.com" <christian.ruppert@...tech.com>,
	"mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Vineet.Gupta1@...opsys.com" <Vineet.Gupta1@...opsys.com>,
	"andriy.shevchenko@...ux.intel.com" 
	<andriy.shevchenko@...ux.intel.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"christian.ruppert@...lis.com" <christian.ruppert@...lis.com>
Subject: Re: [PATCH] i2c: designware: Suppress error message if
 platform_get_irq() returns -EPROBE_DEFER


> > Presented like this I wonder if this merits being a dev_err at all.
> > Wouldn't dev_dbg be more adequate? This might remove the need for the
> > condition and also avoid bothering everyone if something in the platform
> > device structures or device tree is not right.
> > 
> > >  		return irq; /* -ENXIO */
> > >  	}
> 
> We've just had similar discussion related to DW APB UART with Andy here
> https://lkml.org/lkml/2015/3/3/412
> 
> So yes probably we may safely remove error message from here completely.

So, do you want to send a V2?

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)