linux-kernel - Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1425889764.5234.13.camel@synopsys.com>
Date:	Mon, 9 Mar 2015 08:29:24 +0000
From:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:	"wsa@...-dreams.de" <wsa@...-dreams.de>
CC:	"mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Vineet.Gupta1@...opsys.com" <Vineet.Gupta1@...opsys.com>,
	"andriy.shevchenko@...ux.intel.com" 
	<andriy.shevchenko@...ux.intel.com>,
	"christian.ruppert@...tech.com" <christian.ruppert@...tech.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"christian.ruppert@...lis.com" <christian.ruppert@...lis.com>
Subject: Re: [PATCH] i2c: designware: Suppress error message if
 platform_get_irq() returns -EPROBE_DEFER

Hi Wolfram,

On Sat, 2015-03-07 at 01:24 +0100, Wolfram Sang wrote:
> > > Presented like this I wonder if this merits being a dev_err at all.
> > > Wouldn't dev_dbg be more adequate? This might remove the need for the
> > > condition and also avoid bothering everyone if something in the platform
> > > device structures or device tree is not right.
> > > 
> > > >  		return irq; /* -ENXIO */
> > > >  	}
> > 
> > We've just had similar discussion related to DW APB UART with Andy here
> > https://lkml.org/lkml/2015/3/3/412
> > 
> > So yes probably we may safely remove error message from here completely.
> 
> So, do you want to send a V2?

Sorry for this delay - I was away for last few days.
I'm about to send v2 with removal of error message completely.

-Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/