linux-kernel - Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309082956.GA9059@sudip-PC>
Date:	Mon, 9 Mar 2015 14:00:20 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LFBDEV <linux-fbdev@...r.kernel.org>,
	OSUOSL Drivers <devel@...verdev.osuosl.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print

On Mon, Mar 09, 2015 at 07:42:53AM +0000, Lad, Prabhakar wrote:
> On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
> >
> >
> > this patch will give checkpatch warnings about use of printk.
> > this patch was mainly to fix the build warnings. printk will be
> > converted to pr_* and dev_* in a later patch.
> >
> > +       printk("lynxfb mmap pgoff: %lx\n", vma->vm_pgoff);
> > +       printk("lynxfb mmap off 1: %lx\n", off);
> >
> wouldn't it makes sense to change printk to some pr_*() ?
yes, i could have. But usually Greg does not accept patches which is doing more than one type of change. That is why I mentioned in the comments that this will be converted to pr_* and dev_* in a later patch.

regards
sudip

> 
> Cheers,
> --Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/