linux-kernel - Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309124222.GE10964@mwanda>
Date:	Mon, 9 Mar 2015 15:42:22 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function

On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote:
> kbuild test robot reported that for microblaze-allyesconfig
> chan_to_field() and lynxfb_ops_set_par() were not defined. These two
> functions were defined under CONFIG_PM, so for any archtecture if
> CONFIG_PM is not defined we will have this error.
> 
> while moving the lynxfb_suspend() function some very obvious
> checkpatch errors, like space after comma, space after if, space
> before opening brace, were taken care of.

I have a script to review patches moving functions around but these
white space changes break my script so I have to review it by hand.
Sucks.

>  static int lynxfb_ops_set_par(struct fb_info * info)
>  {
>  	struct lynxfb_par * par;
> @@ -369,7 +313,6 @@ static int lynxfb_ops_set_par(struct fb_info * info)
>  	struct fb_fix_screeninfo * fix;
>  	int ret;
>  	unsigned int line_length;
> -	
>  
>  	if(!info)
>  		return -EINVAL;
> @@ -441,6 +384,7 @@ static int lynxfb_ops_set_par(struct fb_info * info)
>  		ret = output->proc_setMode(output,var,fix);
>  	return ret;
>  }
> +
>  static inline unsigned int chan_to_field(unsigned int chan,struct fb_bitfield * bf)
>  {
>  	chan &= 0xffff;

These white space changes are not related.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/