linux-kernel - Re: [PATCH] dgnc: move more repeating code under 'failed' label

Open Source and information security mailing list archives

Message-ID: <20150309130645.GF10964@mwanda>
Date:	Mon, 9 Mar 2015 16:06:45 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>,
	Matteo Semenzato <mattew8898@...il.com>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dgnc: move more repeating code under 'failed' label

Added Matteo to the CC list because he was working on this function as
well and I remembered something I wanted to tell him.

On Sun, Mar 08, 2015 at 07:46:37PM +0200, Giedrius Statkevičius wrote:
> Currently the label is only used to return a error code to the caller but more
> repeating code is before each "goto failed;" thus we can move that code to the
> label. Also, remove some empty unneeded lines together with this patch in those
> if's and at the end of dgnc_found_board().
> 

This function totally sucks.

This patch is useless because we will never use the brd->state in the
cases where we fail.  We shouldn't be saving inconsistent crap into
dgnc_Board[] because that is barf inducing ugly even though it's not a
bug given that we don't use it.

Only do:

	dgnc_Board[dgnc_NumBoards] = brd;

when the brd is fully configured at the end of the dgnc_found_board()
function.

regards,
dan carpenter

> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index fa1ee79..73ee667 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -574,17 +574,12 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
>  	if (rc < 0) {
>  		dgnc_tty_uninit(brd);
>  		pr_err(DRVSTR ": Can't register tty devices (%d)\n", rc);
> -		brd->state = BOARD_FAILED;
> -		brd->dpastatus = BD_NOFEP;
>  		goto failed;
>  	}
>  
>  	rc = dgnc_finalize_board_init(brd);
>  	if (rc < 0) {
>  		pr_err(DRVSTR ": Can't finalize board init (%d)\n", rc);
> -		brd->state = BOARD_FAILED;
> -		brd->dpastatus = BD_NOFEP;
> -
>  		goto failed;
>  	}
>  
> @@ -592,9 +587,6 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
>  	if (rc < 0) {
>  		dgnc_tty_uninit(brd);
>  		pr_err(DRVSTR ": Can't init tty devices (%d)\n", rc);
> -		brd->state = BOARD_FAILED;
> -		brd->dpastatus = BD_NOFEP;
> -
>  		goto failed;
>  	}
>  
> @@ -628,9 +620,9 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
>  	return 0;
>  
>  failed:
> -
> +	brd->state = BOARD_FAILED;
> +	brd->dpastatus = BD_NOFEP;
>  	return -ENXIO;
> -
>  }
>  
>  
> -- 
> 2.3.2
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives