linux-kernel - Re: [PATCH] dgnc: move more repeating code under 'failed' label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 Mar 2015 17:23:49 +0200
From:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Matteo Semenzato <mattew8898@...il.com>
CC:	lidza.louina@...il.com, markh@...pro.net,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dgnc: move more repeating code under 'failed' label

On 2015.03.09 15:06, Dan Carpenter wrote:
> Added Matteo to the CC list because he was working on this function as
> well and I remembered something I wanted to tell him.
> 
> On Sun, Mar 08, 2015 at 07:46:37PM +0200, Giedrius Statkevičius wrote:
>> Currently the label is only used to return a error code to the caller but more
>> repeating code is before each "goto failed;" thus we can move that code to the
>> label. Also, remove some empty unneeded lines together with this patch in those
>> if's and at the end of dgnc_found_board().
>>
> 
> This function totally sucks.
> 
> This patch is useless because we will never use the brd->state in the
> cases where we fail.  We shouldn't be saving inconsistent crap into
> dgnc_Board[] because that is barf inducing ugly even though it's not a
> bug given that we don't use it.
> 
> Only do:
> 
> 	dgnc_Board[dgnc_NumBoards] = brd;
> 
> when the brd is fully configured at the end of the dgnc_found_board()
> function.
> 
> regards,
> dan carpenter

First time I've made this patch I was purely looking at this from a
cosmetical point. But now that I've looked more at this I see that you
have a good point.  I've made a patch that tries to address this issue
and posted it in another thread.

-- 
Thanks,
Giedrius
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/