linux-kernel - Re: [PATCH] x86, selftests: Add sigreturn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150309164522.GB24910@gmail.com>
Date:	Mon, 9 Mar 2015 17:45:23 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Shuah Khan <shuah.kh@...sung.com>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] x86, selftests: Add sigreturn_32 selftest


* Andy Lutomirski <luto@...capital.net> wrote:

> On Mon, Mar 9, 2015 at 9:29 AM, Ingo Molnar <mingo@...nel.org> wrote:
> >
> > * Andy Lutomirski <luto@...capital.net> wrote:
> >
> >> This is my sigreturn test, added mostly unchanged from its old home.
> >>
> >> The integration with the selftest build process seems okay if not
> >> particularly elegant.
> >>
> >> I'm not using the ksft_ helpers at all yet.  I can do that later.
> >
> > Cool!
> >
> > Doesn't seem to build on Ubuntu though:
> >
> > make[1]: Entering directory
> > '/home/mingo/tip/tools/testing/selftests/x86'
> > gcc -m32 -o sigreturn_32 -O2 -g -std=gnu99 -pthread -Wall  sigreturn.c -lrt -ldl
> > sigreturn.c:13:22: fatal error: sys/time.h: No such file or directory
> >  #include <sys/time.h>
> >                       ^
> > compilation terminated.
> > Makefile:18: recipe for target 'sigreturn_32' failed
> >
> > also, run_tests.sh probably wants to be executable?
> 
> I think it is:
> 
> diff --git a/tools/testing/selftests/x86/run_tests.sh
> b/tools/testing/selftests/x86/run_tests.sh
> new file mode 100755

Indeed, I'm using broken tools ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/