linux-kernel - Re: [PATCH 3/4] Added input buffer from the terminal.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150309183830.GY28806@sirena.org.uk>
Date:	Mon, 9 Mar 2015 18:38:30 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Adrian Remonda <adrianremonda@...il.com>
Cc:	corbet@....net, linux-spi@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Added input buffer from the terminal.

On Sat, Mar 07, 2015 at 12:56:34PM -0500, Adrian Remonda wrote:

> +	int ret = 0;
> +	char *pSrc = src;

The kernel coding style doesn't use Hungarian notation...

> +	if (input_tx) {
> +		size = strlen(input_tx+1);
> +		tx = (uint8_t *)malloc(size);
> +		rx = (uint8_t *)malloc(size);

You should never need to cast the return value of malloc() - if it's
needed it's masking some other problem.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)