linux-kernel - Re: [PATCH 1/4] Cleaned hexadecimal dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150309184035.GZ28806@sirena.org.uk>
Date:	Mon, 9 Mar 2015 18:40:35 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Adrian Remonda <adrianremonda@...il.com>
Cc:	corbet@....net, linux-spi@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Cleaned hexadecimal dump

On Sat, Mar 07, 2015 at 12:56:32PM -0500, Adrian Remonda wrote:

> +static void hexDump(const void *src, size_t length, size_t bLine, char *prefix)
> +{

Please call this hex_dump or something - that's more in line with the
kernel coding style.  Please also don't vUse aHungarian nNotation, it's
also not the kernel coding style.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)