linux-kernel - Re: [PATCH 3/4] x86: save user rsp in pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrV3RsKb=8_Ghr0Mi7QPn72-fiZRF0-no_E_=kLwrN_T4Q@mail.gmail.com>
Date:	Mon, 9 Mar 2015 13:43:04 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Denys Vlasenko <vda.linux@...glemail.com>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>, Oleg Nesterov <oleg@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Will Drewry <wad@...omium.org>,
	Kees Cook <keescook@...omium.org>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] x86: save user rsp in pt_regs->sp on SYSCALL64 fastpath

On Mon, Mar 9, 2015 at 1:32 PM, Denys Vlasenko <vda.linux@...glemail.com> wrote:
> On Mon, Mar 9, 2015 at 9:11 PM, Andy Lutomirski <luto@...capital.net> wrote:
>>> @@ -253,11 +247,13 @@ GLOBAL(system_call_after_swapgs)
>>>          */
>>>         ENABLE_INTERRUPTS(CLBR_NONE)
>>>         ALLOC_PT_GPREGS_ON_STACK 8              /* +8: space for orig_ax */
>>> +       movq    %rcx,RIP(%rsp)
>>> +       movq    PER_CPU_VAR(old_rsp),%rcx
>>> +       movq    %r11,EFLAGS(%rsp)
>>> +       movq    %rcx,RSP(%rsp)
>>> +       movq_cfi rax,ORIG_RAX
>>>         SAVE_C_REGS_EXCEPT_RAX_RCX_R11
>>>         movq    $-ENOSYS,RAX(%rsp)
>>> -       movq_cfi rax,ORIG_RAX
>>> -       movq    %r11,EFLAGS(%rsp)
>>> -       movq    %rcx,RIP(%rsp)
>>
>> Why the reordering?
>
> No strong reason.
>
> iret stack is "above" the rest of pt_regs.
>
> This does not matter now, but when/if we convert to PUSHes
> for register saving, pushes which build iret frame
> will have to be before "save C-clobbered registers" part,
> exactly as in this patch.

Fair enough.

Acked-by: Andy Lutomirski <luto@...capital.net>

-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/