linux-kernel - Re: Bad rpath in cpupower with 4.0-rcX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA6Jo9LTbhduCs0eYXJxmdG-39PR-fOKmABNLO2F3btXUA@mail.gmail.com>
Date:	Tue, 10 Mar 2015 08:33:54 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Thomas Renninger <trenn@...e.de>
Cc:	"sriram@...irs.net.in" <sriram@...irs.net.in>,
	Linux PM list <linux-pm@...r.kernel.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: Bad rpath in cpupower with 4.0-rcX

On Fri, Mar 6, 2015 at 8:47 AM, Josh Boyer <jwboyer@...oraproject.org> wrote:
> Hi All,
>
> Commit 5c1de006e8e66 (cpupower Makefile change to help run the tool
> without 'make install') added an rpath to the cpupower binary.  From
> what I can understand, this is to make it easier to run cpupower from
> the local build directory without having to run make install.  It does
> accomplish that, but it also leaves the binary with the rpath in it
> which is considered bad practice.  It also causes cpupower to fail in
> rpmbuild with the following error:
>
> ERROR   0004: file '/usr/bin/cpupower' contains an insecure rpath './'
> in [./]
> error: Bad exit status from /var/tmp/rpm-tmp.A6u26r (%install)
>     Bad exit status from /var/tmp/rpm-tmp.A6u26r (%install)
>
> I understand the want for eased development, but couldn't people just
> set LD_LIBRARY_PATH instead?

No comments on this?  Should I just send a revert patch instead?

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/