linux-kernel - Auto re-negotiation has to triggered when the phy is up while configuring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CADoAD8Ky__1P_+LySu5wzcuVBgNKT1aT+kqCUttkmc7UhSO6vg@mail.gmail.com>
Date:	Wed, 11 Mar 2015 13:54:00 +0530
From:	niyas mydeen <aniyas15@...il.com>
To:	tpiepho@...escale.com, Sandeep.Kumar@...escale.com,
	galak@...escale.com, linux-kernel@...r.kernel.org
Subject: Auto re-negotiation has to triggered when the phy is up while configuring

Working on a PowerPC based custom board with linux3.10 gianfar
ethernet driver, Come across a suitaion where the driver seems to be
not going for an auto negotion when phy is up.

If the link is up when configuring the PHY, autoneg should always be re-
negotiated, since uboot might have a different opinion about the link
parameters.

the commit bdb59f949d663b7e943fb5f40b2557af4314abf9 does seem to be
stopping the driver to go for an auto negotiation..

Below the commits snipet

+       /* If the link is already up, we must already be ok, and don't need to
+        * configure and reset the TBI<->SerDes link.  Maybe U-Boot configured
+        * everything for us?  Resetting it takes the link down and requires
+        * several seconds for it to come back.
+        */
+       if (gfar_local_mdio_read(regs, tbipa, MII_BMSR) & BMSR_LSTATUS)
+               goto done;
+
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/