linux-kernel - Re: [PATCH] ceph: use msecs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAM7YAkYHE3FN3ZkCspc8DgMccVqNtP8TGQOxF_0sC+GE7k2Ug@mail.gmail.com>
Date:	Wed, 11 Mar 2015 18:13:48 +0800
From:	"Yan, Zheng" <ukernel@...il.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Sage Weil <sage@...tank.com>,
	ceph-devel <ceph-devel@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: use msecs_to_jiffies for time conversion

On Fri, Feb 6, 2015 at 7:52 PM, Nicholas Mc Guire <hofrat@...dl.org> wrote:
> This is only an API consolidation and should make things more readable
> it replaces var * HZ / 1000 by msecs_to_jiffies(var).
>
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
>
> Patch was only compile tested with x86_64_defconfig + CONFIG_CEPH_FS=m
>
> Patch is against 3.19.0-rc7 (localversion-next is -next-20150204)
>
>  fs/ceph/mds_client.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 5f62fb7..ced7503 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -3070,7 +3070,7 @@ static void handle_lease(struct ceph_mds_client *mdsc,
>                     di->lease_renew_from &&
>                     di->lease_renew_after == 0) {
>                         unsigned long duration =
> -                               le32_to_cpu(h->duration_ms) * HZ / 1000;
> +                               msecs_to_jiffies(le32_to_cpu(h->duration_ms));
>
>                         di->lease_seq = seq;
>                         dentry->d_time = di->lease_renew_from + duration;
> --
> 1.7.10.4

added to our testing branch

Thanks
Yan, Zheng
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/