linux-kernel - Re: [PATCH 03/45] headers_install.sh: enhance error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Mar 2015 11:16:11 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Mikko Rapeli <mikko.rapeli@....fi>
CC:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Javier Barrio <javier.barrio.mart@...il.com>
Subject: Re: [PATCH 03/45] headers_install.sh: enhance error handling

On 2015-03-10 23:44, Mikko Rapeli wrote:
> On Tue, Feb 17, 2015 at 02:17:51PM +0100, Michal Marek wrote:
>> On 2015-02-17 00:05, Mikko Rapeli wrote:
>>> Exit with error if using undefined variables or if any sub command fails
>>> with error return value. unidef needs special handling since but this can
>>> be done without the trap. Enables exaniming intermediate files if some
>>> commands failed.
>>
>> The intermediate files are removed by your patch as well, aren't they?
>> Actually, I don't see any change in behavior after your patch.
> 
> Yes, if everything succeeded without errors, then intermediate files
> are removed. But the files are left around if something fails

They are not:

+		"$SRCDIR/$i" > "$OUTDIR/$FILE.sed" || \
+		( rm -f "$OUTDIR/$FILE.sed" ; exit 1 )

This removes "$OUTDIR/$FILE.sed" if the sed command files. Just like the
trap command has been doing.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/