linux-kernel - Re: [PATCH v1 2/2] x86: kconfig: remove X86_UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <55015F690200007800068D86@mail.emea.novell.com>
Date:	Thu, 12 Mar 2015 08:42:01 +0000
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
Cc:	<luto@...capital.net>, <thomas.petazzoni@...e-electrons.com>,
	<andy.shevchenko@...il.com>, <bhelgaas@...gle.com>,
	<rientjes@...gle.com>, "Ingo Molnar" <mingo@...nel.org>,
	<x86@...nel.org>, <tglx@...utronix.de>,
	<pure.logic@...us-software.ie>, <mingo@...hat.com>,
	"Juergen Gross" <JGross@...e.com>,
	"Luis Rodriguez" <Mcgrof@...e.com>, <bp@...e.de>,
	<linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<hpa@...or.com>
Subject: Re: [PATCH v1 2/2] x86: kconfig: remove X86_UP_APIC

>>> On 12.03.15 at 00:10, <mcgrof@...not-panic.com> wrote:
>  config X86_LOCAL_APIC
>  	def_bool y
> -	depends on X86_64 || SMP || X86_32_NON_STANDARD || X86_UP_APIC || PCI_MSI
> +	depends on X86_64 || SMP || X86_32_NON_STANDARD || PCI_MSI

I.e. building a 32-bit kernel with APIC support but with !SMP, !PCI_MSI,
and !X86_32_NON_STANDARD will now be impossible. Surely not
what the patch description says.

> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -5,6 +5,8 @@ config PCI_MSI
>  	bool "Message Signaled Interrupts (MSI and MSI-X)"
>  	depends on PCI
>  	select GENERIC_MSI_IRQ
> +	select X86_LOCAL_APIC
> +	select X86_IO_APIC

I don't see the need for the latter - MSI specifically works without
any IO-APIC interaction. And for the former you should decide
which way you want it - PCI_MSI select X86_LOCAL_APIC
(probably the right thing in x86, but surely wrong everwhere
else, i.e. this at least needs a condition tagged onto it) or
X86_LOCAL_APIC depend on PCI_MSI; in no case should this
be a forward _and_ reverse dependency.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/