linux-kernel - Re: [PATCH 1/1 linux-next] UBIFS: simplify returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Mar 2015 11:20:56 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Artem Bityutskiy <dedekind1@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	MTD Maling List <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH 1/1 linux-next] UBIFS: simplify returns

Hi Fabian,

On Wed, Mar 11, 2015 at 6:44 PM, Fabian Frederick <fabf@...net.be> wrote:
> @@ -1002,13 +999,9 @@ static int clean_an_unclean_leb(struct ubifs_info *c,
>
>         dbg_rcvry("LEB %d len %d", lnum, len);
>
> -       if (len == 0) {
> +       if (len == 0)
>                 /* Nothing to read, just unmap it */
> -               err = ubifs_leb_unmap(c, lnum);
> -               if (err)
> -                       return err;
> -               return 0;
> -       }
> +               return ubifs_leb_unmap(c, lnum);

While technically the curly braces are no longer needed, I'd keep them
because of the comment line.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/