linux-kernel - Re: [PATCH 2/2] drm/bridge: Add IT6151 bridge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13714812.stPyeO78Dq@phil>
Date:	Thu, 12 Mar 2015 11:24:10 +0100
From:	Heiko Stuebner <heiko@...ech.de>
To:	linux-mediatek@...ts.infradead.org, CK Hu <ck.hu@...iatek.com>
Cc:	Paul Bolle <pebolle@...cali.nl>,
	Mark Rutland <mark.rutland@....com>,
	devicetree@...r.kernel.org, Jitao Shi <jitao.shi@...iatek.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	srv_heupstream@...iatek.com, David Airlie <airlied@...ux.ie>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Rob Herring <robh+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH 2/2] drm/bridge: Add IT6151 bridge driver

Am Donnerstag, 12. März 2015, 10:00:47 schrieb Paul Bolle:
> > --- /dev/null
> > +++ b/drivers/gpu/drm/bridge/it6151.c
> > 
> > +#include <linux/module.h>
> 
> This file can only be built-in. So I couldn't help but notice this
> include. And if I remove it
>     make drivers/gpu/drm/bridge/it6151.o
> 
> still runs without warning or errors. Unless I've missed something
> non-obvious I'd say it is not needed.

I think the more interesting question would be, why can it only be built in 
:-) .

The drm/bridge series from Ajay Kumar [0] made it into 4.0-rc that enables 
drm-bridges to be regular platform/i2c devices, see [1] for example.

So I think any new bridge driver should use this approach and can thus also be 
build as module.


Heiko


[0] http://www.spinics.net/lists/linux-samsung-soc/msg41403.html
[1] http://www.spinics.net/lists/linux-samsung-soc/msg41406.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/