linux-kernel - Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55018855.9090301@cogentembedded.com>
Date:	Thu, 12 Mar 2015 15:36:37 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Scott Wood <scottwood@...escale.com>, trivial@...nel.org,
	linux-kernel@...r.kernel.org
CC:	linux-usb@...r.kernel.org, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers

Hello.

On 3/12/2015 6:13 AM, Scott Wood wrote:

> Use %pS for actual addresses, otherwise you'll get bad output

    %pS or %ps?

> on arches like ppc64 where %pF expects a function descriptor.

    %pF or %pf? And what is a function descriptor?

> Signed-off-by: Scott Wood <scottwood@...escale.com>
> Cc: linux-usb@...r.kernel.org
> Cc: Felipe Balbi <balbi@...com>
[...]

> diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
> index 491082a..89179ab 100644
> --- a/drivers/usb/gadget/function/u_serial.c
> +++ b/drivers/usb/gadget/function/u_serial.c
> @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
>   	unsigned long	flags;
>   	int		status;
>
> -	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
> +	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n",
>   		port->port_num, tty, ch, __builtin_return_address(0));
[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/