linux-kernel - Re: [Jfs-discussion] [PATCH 19/22] jfs: %pF is only for function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55019FB7.1000806@oracle.com>
Date:	Thu, 12 Mar 2015 09:16:23 -0500
From:	Dave Kleikamp <dave.kleikamp@...cle.com>
To:	Scott Wood <scottwood@...escale.com>, trivial@...nel.org,
	linux-kernel@...r.kernel.org
CC:	jfs-discussion@...ts.sourceforge.net
Subject: Re: [Jfs-discussion] [PATCH 19/22] jfs: %pF is only for function
 pointers

On 03/11/2015 10:13 PM, Scott Wood wrote:
> Use %pS for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pF expects a function descriptor.
> 
> Signed-off-by: Scott Wood <scottwood@...escale.com>
> Cc: jfs-discussion@...ts.sourceforge.net
Acked-by: Dave Kleikamp <dave.kleikamp@...cle.com>

Do you intend to submit these as a set, or would you rather I push this
one through the jfs subsystem?

Thanks,
Shaggy

> ---
>  fs/jfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 5d30c56..4cd9798 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -102,7 +102,7 @@ void jfs_error(struct super_block *sb, const char *fmt, ...)
>  	vaf.fmt = fmt;
>  	vaf.va = &args;
>  
> -	pr_err("ERROR: (device %s): %pf: %pV\n",
> +	pr_err("ERROR: (device %s): %ps: %pV\n",
>  	       sb->s_id, __builtin_return_address(0), &vaf);
>  
>  	va_end(args);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/