linux-kernel - Re: [PATCH 4/6] perf kmem: Analyze page allocator events also

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150312151147.GB1398@danjae>
Date:	Fri, 13 Mar 2015 00:11:47 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Minchan Kim <minchan@...nel.org>,
	Joonsoo Kim <js1304@...il.com>
Subject: Re: [PATCH 4/6] perf kmem: Analyze page allocator events also

Hi Jiri,

On Thu, Mar 12, 2015 at 12:01:27PM +0100, Jiri Olsa wrote:
> On Thu, Mar 12, 2015 at 04:32:49PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > +static int parse_slab_opt(const struct option *opt __maybe_unused,
> > +			  const char *arg __maybe_unused,
> > +			  int unset __maybe_unused)
> > +{
> > +	kmem_slab = (kmem_page + 1);
> > +	return 0;
> > +}
> > +
> > +static int parse_page_opt(const struct option *opt __maybe_unused,
> > +			  const char *arg __maybe_unused,
> > +			  int unset __maybe_unused)
> > +{
> > +	kmem_page = (kmem_slab + 1);
> > +	return 0;
> > +}
> 
> hum, just curious.. why not just assign 1, I'm missing the magic ;-)

Well, basically I just followed the existing convention. :)

Anyway it controls the effect of -s/--sort option.  The single -s
option will be used to set sort keys for both of --alloc and --caller
stat.  So it needs to known currently selected mode at option parsing
time.  I extended it to page/slab selection also.

For example,

  # perf kmem --page --alloc -s bytes --slab --caller -s hit

The first -s option will set sort keys for page/alloc stat and the
second -s option will set sort keys for slab/caller stat.  So the -s
option should be preceded by at least one of the mode selection
options (i.e. --page/slab/alloc/caller).  I'll add it to the man page
also.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/