[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1426186182.30327.127.camel@freescale.com>
Date: Thu, 12 Mar 2015 13:49:42 -0500
From: Scott Wood <scottwood@...escale.com>
To: Sam Ravnborg <sam@...nborg.org>
CC: <trivial@...nel.org>, <linux-kernel@...r.kernel.org>,
<sparclinux@...r.kernel.org>
Subject: Re: [PATCH 12/22] sparc: %pF is only for function pointers
On Thu, 2015-03-12 at 19:47 +0100, Sam Ravnborg wrote:
> On Wed, Mar 11, 2015 at 10:13:47PM -0500, Scott Wood wrote:
> > Use %pS for actual addresses, otherwise you'll get bad output
> > on arches like ppc64 where %pF expects a function descriptor. Even on
> > other architectures, refrain from setting a bad example that people
> > copy.
>
> The commit message used uppercase 'S' and 'F'.
> But the patch uses lowercase variants.
>
> Is this to highlight the letter in the commit message or some unwanted inconsistency?
It was copy and paste from others in the series that did involve the
capital version. I can send a v2 with an updated commit message.
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists