linux-kernel - Re: [PATCH 12/22] sparc: %pF is only for function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150312185454.GA22576@ravnborg.org>
Date:	Thu, 12 Mar 2015 19:54:54 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Scott Wood <scottwood@...escale.com>
Cc:	trivial@...nel.org, linux-kernel@...r.kernel.org,
	sparclinux@...r.kernel.org
Subject: Re: [PATCH 12/22] sparc: %pF is only for function pointers

On Thu, Mar 12, 2015 at 01:49:42PM -0500, Scott Wood wrote:
> On Thu, 2015-03-12 at 19:47 +0100, Sam Ravnborg wrote:
> > On Wed, Mar 11, 2015 at 10:13:47PM -0500, Scott Wood wrote:
> > > Use %pS for actual addresses, otherwise you'll get bad output
> > > on arches like ppc64 where %pF expects a function descriptor.  Even on
> > > other architectures, refrain from setting a bad example that people
> > > copy.
> > 
> > The commit message used uppercase 'S' and 'F'.
> > But the patch uses lowercase variants.
> > 
> > Is this to highlight the letter in the commit message or some unwanted inconsistency?
> 
> It was copy and paste from others in the series that did involve the
> capital version.  I can send a v2 with an updated commit message.
As it confused me someone else migth (maybe the chances are small but anyway) be confused too.
So please send a new version.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/