| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150315101758.GA28477@opentech.at> Date: Sun, 15 Mar 2015 11:17:58 +0100 From: Nicholas Mc Guire <der.herr@...r.at> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: Nicholas Mc Guire <hofrat@...dl.org>, Kalle Valo <kvalo@....qualcomm.com>, Michal Kazior <michal.kazior@...to.com>, ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] ath10k: core: harmonize error case handling in ath10k_core_start On Sat, 14 Mar 2015, Sergei Shtylyov wrote: > Hello. > > On 03/14/2015 11:55 AM, Nicholas Mc Guire wrote: > >> All of the bringup/init functions called in ath10k_core_start return 0 on >> success and != 0 on failure - ath10k_wmi_wait_for_service_ready and >> ath10k_wmi_wait_for_unified_ready were adjusted to fit this model and the >> call sites here fixed up accordingly. > > If you've changed the sense of these function's results, you need to > adjust the call sites in the same patch, because otherwise one wouldn't > be able to bisect this... > yup both patches would mess up if individually applied or reverted. sorry my ignorance - did not think of that problem - will fix it up as a single patch and repost. thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists