linux-kernel - Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55074F04.2070700@gmail.com>
Date:	Mon, 16 Mar 2015 22:45:40 +0100
From:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	gregkh@...uxfoundation.org, joe@...ches.com,
	devel@...verdev.osuosl.org, mdcasey@...bloom.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge
 broken strings)

On 16.03.2015 09:44, Dan Carpenter wrote:
> On Fri, Mar 13, 2015 at 12:53:16AM +0100, Mateusz Kulikowski wrote:
>> -			RT_TRACE(COMP_RECV, "HwRateToMRate90(): Non supported"
>> -				 "Rate [%x], bIsHT = %d!!!\n", rate, bIsHT);
>> -						  break;
>> +			RT_TRACE(COMP_RECV,
>> +				 "HwRateToMRate90(): Non supportedRate [%x], bIsHT = %d!!!\n",
> 
> There should be a space character between "supported" and "Rate".  You
> can fix it in a later patch though, it's minor.  And really no one cares
> about RT_TRACE() output.

Thanks for the hint - there is a lot of other typos in messages - I will probably fix them later on;

As for RT_TRACE - my plan is to replace the whole "proprietary logging system" with dynamic debug 
(i.e. netdev_dbg() or pr_debug()), but again - this is bigger patch and I'll prepare it after this series is merged.


Regards,
Mateusz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/