lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Mar 2015 22:57:59 +0100 From: Mateusz Kulikowski <mateusz.kulikowski@...il.com> To: Joe Perches <joe@...ches.com> CC: gregkh@...uxfoundation.org, mdcasey@...bloom.com, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) On 13.03.2015 01:27, Joe Perches wrote: > > Another thing you might consider is to change these > embedded function names in another patch to use > "%s: ", __func__ > > RT_TRACE(COMP_ERR, > "%s: "unknown hardware version\n", > __func__) > > There's a cocci script for that. > http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names This tool (coccinelle) looks great - I will once take look at it and do swap like suggested; It probably can be used to cleanup other parts of this driver as well - if I knew about it earlier it would save me a lot of repetitive work. Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists