linux-kernel - Re: [PATCH V8 04/10] USB: f81232: implement read IIR/MSR with endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 17:18:11 +0800
From:	Peter Hung <hpeter@...il.com>
To:	Johan Hovold <johan@...nel.org>
CC:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, tom_tsai@...tek.com.tw,
	peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V8 04/10] USB: f81232: implement read IIR/MSR with endpoint

Hello,

Johan Hovold 於 2015/3/16 下午 04:55 寫道:
> On Mon, Mar 16, 2015 at 11:08:29AM +0800, Peter Hung wrote:
>>> Could you rewrite this as
>>>
>>> 	if (status < 0)
>>> 		status = usb_translate_errors(status);
>>> 	else
>>> 		status = 0;
>>
>> In my definition the return value of set/getregister(), 0 is success,
>> negative values are errors. The function usb_control_msg() return value
>> is success transmited/received byte. It's maybe return 0. I want to
>> treat 0 with error(-EIO). But if pass 0 to usb_translate_errors(), It
>> will return 0 back. So I need especially handle with status == 0.
>
> I meant to write
>
> 	if (status < 0)
>   		status = usb_translate_errors(status);
> 	else
> 		status = -EIO;
>
> which I think is more readable.

It's looks more readable of the style that you mentioned.
Thanks for your advice, I'll add it with next patch.

-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/