linux-kernel - Re: [PATCH] printk: Use symbolic defines for console loglevels instead of numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 10:20:28 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Tony Lindgren <tony@...mide.com>,
	Russell King <linux@....linux.org.uk>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Gavin Shan <gwshan@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] printk: Use symbolic defines for console loglevels
 instead of numbers

On Mon, Mar 16, 2015 at 10:01 AM, Alexander Kuleshov
<kuleshovmail@...il.com> wrote:
> --- a/arch/m68k/mac/macints.c
> +++ b/arch/m68k/mac/macints.c
> @@ -315,7 +315,7 @@ irqreturn_t mac_nmi_handler(int irq, void *dev_id)
>         while (nmi_hold == 1)
>                 udelay(1000);
>
> -       if (console_loglevel >= 8) {
> +       if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG) {

CONSOLE_LOGLEVEL_DEBUG == 10, not 8

As there's no define for 8, perhaps you can use:

"if (console_loglevel > CONSOLE_LOGLEVEL_DEFAULT) {"

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/