linux-kernel - Re: [PATCH v2 10/16] staging: rtl8723au: that open brace should be on the previous line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Mar 2015 12:36:04 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	"M. Vefa Bicakci" <m.v.b@...box.com>
Cc:	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	joe@...ches.com, Larry.Finger@...inger.net,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH v2 10/16] staging: rtl8723au: that open brace should be on the previous line

"M. Vefa Bicakci" <m.v.b@...box.com> writes:
> Correct two instances of the checkpatch.pl error indicating that the
> opening curly braces should not be on new lines:
> 	ERROR: that open brace { should be on the previous line
>
> Signed-off-by: M. Vefa Bicakci <m.v.b@...box.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_security.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
> index 803f8965a4..2d762276d3 100644
> --- a/drivers/staging/rtl8723au/core/rtw_security.c
> +++ b/drivers/staging/rtl8723au/core/rtw_security.c
> @@ -760,8 +760,7 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
>  
>  	*((u32 *)crc) = le32_to_cpu(getcrc32(payload, length - 4));
>  
> -	if (crc[3] != payload[length - 1] || crc[2] != payload[length - 2] || crc[1] != payload[length - 3] || crc[0] != payload[length - 4])
> -	{
> +	if (crc[3] != payload[length - 1] || crc[2] != payload[length - 2] || crc[1] != payload[length - 3] || crc[0] != payload[length - 4]) {
>  	    RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("rtw_wep_decrypt23a:icv error crc[3](%x)!= payload[length-1](%x) || crc[2](%x)!= payload[length-2](%x) || crc[1](%x)!= payload[length-3](%x) || crc[0](%x)!= payload[length-4](%x)\n",
>  				crc[3], payload[length - 1], crc[2], payload[length - 2], crc[1], payload[length - 3], crc[0], payload[length - 4]));
>  		res = _FAIL;

If you are mangling a line like this, don't just fix one ugliness, fix
it up properly by breaking down the line to avoid the > 80 character
mess.

Cheers,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/