linux-kernel - Re: [PATCH v2 15/16] staging: rtl8723au: Correct a typo in a trace log line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wrfj1tkosxsk.fsf@ultrasam.lan.trained-monkey.org>
Date:	Mon, 16 Mar 2015 12:38:03 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	"M. Vefa Bicakci" <m.v.b@...box.com>
Cc:	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	joe@...ches.com, Larry.Finger@...inger.net,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH v2 15/16] staging: rtl8723au: Correct a typo in a trace log line

"M. Vefa Bicakci" <m.v.b@...box.com> writes:
> Correct a typo in rtl8723au's rtw_security.c which was most likely
> caused by a copy and paste mistake. Prior to this commit, the TKIP
> decryption function referred to WEP in its trace log output.
>
> Signed-off-by: M. Vefa Bicakci <m.v.b@...box.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_security.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c
> index eb3544866a..e8d3ce53bb 100644
> --- a/drivers/staging/rtl8723au/core/rtw_security.c
> +++ b/drivers/staging/rtl8723au/core/rtw_security.c
> @@ -757,7 +757,7 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
>  
>  	if (actual_crc != expected_crc) {
>  		RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
> -			 ("rtw_wep_decrypt23a:icv CRC mismatch: "
> +			 ("rtw_tkip_decrypt23a:icv CRC mismatch: "

If you made this ("%s:icv ....", __func__, ....

you wouldn't have to worry about matching the function name to the debug
text, in case the function later got renamed.

Cheers,
Jes

>  			  "actual: %08x, expected: %08x\n",
>  			  actual_crc, expected_crc));
>  		res = _FAIL;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/