linux-kernel - Re: [PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2015 11:31:59 -0500
From:	Nishanth Menon <nm@...com>
To:	santosh shilimkar <santosh.shilimkar@...cle.com>,
	Tony Lindgren <tony@...mide.com>,
	Stefan Hengelein <stefan.hengelein@....de>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux@....linux.org.uk>, <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688

On 03/17/2015 11:26 AM, santosh shilimkar wrote:
> 
> 
> On 3/16/2015 4:30 PM, Tony Lindgren wrote:
>> * Stefan Hengelein <stefan.hengelein@....de> [150225 10:48]:
>>> The Kconfig-Option OMAP4_ERRATA_I688 is never visible due to a
>>> contradiction in it's dependencies.
>>> The option requires ARCH_MULTIPLATFORM to be 'disabled'. However, an
>>> enclosing menu requires either ARCH_MULTI_V6 or ARCH_MULTI_V7 to be
>>> enabled. These options inherit a dependency from an enclosing menu,
>>> that requires ARCH_MULTIPLATFORM to be 'enabled'.
>>> This is a contradiction and made this option also unavailable for
>>> non-multiplatform configurations.
>>>
>>> Since there are no selects on OMAP4_ERRATA_I688, which would ignore
>>> dependencies, the code related to that option is dead and can be
>>> removed.
>>>
>>> This (logical) defect has been found with the undertaker tool.
>>> (https://undertaker.cs.fau.de)
>>>
>>> Signed-off-by: Stefan Hengelein <stefan.hengelein@....de>
>>>
>>> ---
>>> Tony Lindgren suggested to remove the code since nobody complained for
>>> a few years and Santosh Shilimkar agreed.
>>> https://lkml.org/lkml/2015/2/25/449
>>> ---
>>> As far as I see, this should remove all the code related to
>>> OMAP4_ERRATA_I688, I hope I didn't remove too much.
>>
>> Seems to boot fine, so applying into omap-for-v4.1/fixes-not-urgent.
>>
> Acked-by: Santosh Shilimkar <ssantosh@...nel.org>

We no longer need i688? I do understand the need to cleanup the macros
for multi-arch etc.. but loosing a bug workaround for a real silicon
bug is really an invitation for hard to debug issues IMHO.


-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/