linux-kernel - Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150318122854.GA18070@kroah.com>
Date:	Wed, 18 Mar 2015 13:28:54 +0100
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Felipe Balbi <balbi@...com>, linux-usb@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Douglas Gilbert <dgilbert@...erlog.com>,
	Robert Nelson <robert.nelson@...ikey.com>
Subject: Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling

On Wed, Mar 18, 2015 at 12:16:22PM +0100, Nicolas Ferre wrote:
> Le 17/03/2015 20:01, Alan Stern a écrit :
> > On Tue, 17 Mar 2015, Boris Brezillon wrote:
> > 
> >> The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk)
> >> clocks to work properly. Remove the useless system clock (fclk).
> >>
> >> Avoid calling set_rate on the fixed rate UTMI/IPLL clock and remove
> >> useless IS_ENABLED(CONFIG_COMMON_CLK) tests (all at91 platforms have been
> >> moved to the CCF).
> >>
> >> This patch also fixes a bug introduced by 3440ef1 (ARM: at91/dt: fix USB
> >> high-speed clock to select UTMI), which was leaving the usb clock
> >> uninitialized and preventing the OHCI driver from setting the usb clock
> >> rate to 48MHz.
> >> This bug was caused by several things:
> >> 1/ usb clock drivers set the CLK_SET_RATE_GATE flag, which means the rate
> >>    cannot be changed once the clock is prepared
> >> 2/ The EHCI driver was retrieving and preparing/enabling the uhpck
> >>    clock which was in turn preparing its parent clock (the usb clock),
> >>    thus preventing any rate change because of 1/
> >>
> >> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> > 
> > Acked-by: Alan Stern <stern@...land.harvard.edu>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
> and:
> Fixes: 3440ef169100 ("ARM: at91/dt: fix USB high-speed clock to select UTMI")
> 
> Alan, Greg,
> 
> Can you please take this patch (only this patch 1/5 of the series) as a fix 
> for the 4.0-rc? It would solve the issue that we see on at91sam9x5/at91sam9n12.
> I'll take care of the rest of the series for 4.1.
> 
> If you want me to take it of to re-send the patch, tell me.

I'll queue it up now, thanks.  You can take the rest of the series :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/