linux-kernel - Re: [PATCH RFC] wimax/i2400m: fixup completion handling for resetting a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55096FA1.9030908@cogentembedded.com>
Date:	Wed, 18 Mar 2015 15:29:21 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>,
	Inaky Perez-Gonzalez <inaky.perez-gonzalez@...el.com>
CC:	linux-wimax@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] wimax/i2400m: fixup completion handling for resetting
 a device

Hello.

On 3/17/2015 12:49 PM, Nicholas Mc Guire wrote:

> wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the check
> for > 0 in the else branch is always true and can be dropped. The comment seems
> misleading as it is always going to pass the result up.

> The sync of the completion access with __i2400m_dev_reset_handle (which checks
> for   if (i2400m->reset_ctx)   could race if i2400m_reset() returns negative so
> the resetting of i2400m->reset_ctx == NULL is moved to the out: path.

> As wait_for_completion_timeout returns unsigned long not int, an appropriately
> named variable of type unsigned long is added and assignments fixed up.

    Don't try to do several things in one patch.

> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/