linux-kernel - Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D12F33AE.E6D1A%andreas.dilger@intel.com>
Date:	Wed, 18 Mar 2015 19:53:35 +0000
From:	"Dilger, Andreas" <andreas.dilger@...el.com>
To:	Maxime Lorrillere <maxime.lorrillere@...6.fr>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"laure.millet@...6.fr" <laure.millet@...6.fr>
Subject: Re: [PATCH] staging: lustre: namei.c: coding style: fix 80
 characters limit

On 2015/03/18, 1:07 PM, "Maxime Lorrillere" <maxime.lorrillere@...6.fr>
wrote:

>From: Laure Millet <laure.millet@...6.fr>
>
>This patch fixes lines over 80 characters

I think the newer rule is that strings shouldn't be split across lines.
That makes
the first hunk invalid, though the second one is OK.


Cheers, Andreas

>Signed-off-by: Laure Millet <laure.millet@...6.fr>
>Signed-off-by: Maxime Lorrillere <maxime.lorrillere@...6.fr>
>---
> drivers/staging/lustre/lustre/llite/namei.c |    6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/llite/namei.c
>b/drivers/staging/lustre/lustre/llite/namei.c
>index 3fa529d..49f1cb0 100644
>--- a/drivers/staging/lustre/lustre/llite/namei.c
>+++ b/drivers/staging/lustre/lustre/llite/namei.c
>@@ -83,7 +83,8 @@ static int ll_set_inode(struct inode *inode, void
>*opaque)
> 
> 	lli->lli_fid = body->fid1;
> 	if (unlikely(!(body->valid & OBD_MD_FLTYPE))) {
>-		CERROR("Can not initialize inode " DFID " without object type: valid =
>%#llx\n",
>+		CERROR("Can not initialize inode " DFID
>+		       " without object type: valid = %#llx\n",
> 		       PFID(&lli->lli_fid), body->valid);
> 		return -EINVAL;
> 	}
>@@ -600,7 +601,8 @@ static int ll_atomic_open(struct inode *dir, struct
>dentry *dentry,
> 	long long lookup_flags = LOOKUP_OPEN;
> 	int rc = 0;
> 
>-	CDEBUG(D_VFSTRACE, "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags
>%x,mode %x opened %d\n",
>+	CDEBUG(D_VFSTRACE,
>+	       "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags %x,mode %x
>opened %d\n",
> 	       dentry, dir->i_ino,
> 	       dir->i_generation, dir, file, open_flags, mode, *opened);
> 
>-- 
>1.7.10.4
>
>


Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/