linux-kernel - Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150318203022.GA3288@kroah.com>
Date:	Wed, 18 Mar 2015 21:30:22 +0100
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	"Dilger, Andreas" <andreas.dilger@...el.com>
Cc:	Maxime Lorrillere <maxime.lorrillere@...6.fr>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"laure.millet@...6.fr" <laure.millet@...6.fr>
Subject: Re: [PATCH] staging: lustre: namei.c: coding style: fix 80
 characters limit

On Wed, Mar 18, 2015 at 07:53:35PM +0000, Dilger, Andreas wrote:
> On 2015/03/18, 1:07 PM, "Maxime Lorrillere" <maxime.lorrillere@...6.fr>
> wrote:
> 
> >From: Laure Millet <laure.millet@...6.fr>
> >
> >This patch fixes lines over 80 characters
> 
> I think the newer rule is that strings shouldn't be split across lines.
> That makes
> the first hunk invalid, though the second one is OK.

No, that first hunk is just fine, that horrid DFID macro allows it to
now be split :)

To fix this correctly, you need to move to using the "real" in-kernel
pr_err() functions, not custom macros.  When that happens, checkpatch.pl
will stop complaining.

I'll take this one as-is.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/