linux-kernel - Re: [PATCH 2/2] Staging: lustre: lnet: lnet: router.c: fix useless statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2015 23:01:11 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Redha Gouicem <redha.gouicem@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: lustre: lnet: lnet: router.c: fix useless
 statements

On Wed, Mar 18, 2015 at 10:45:47PM +0100, Redha Gouicem wrote:
> This patch removes useless returns and elses.
> 
> Signed-off-by: Redha Gouicem <redha.gouicem@...il.com>
> ---
>  drivers/staging/lustre/lnet/lnet/router.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
> index 89a29b7..6fe79e2 100644
> --- a/drivers/staging/lustre/lnet/lnet/router.c
> +++ b/drivers/staging/lustre/lnet/lnet/router.c
> @@ -270,7 +270,6 @@ static void lnet_shuffle_seed(void)
>  	do_gettimeofday(&tv);
>  	cfs_srand(tv.tv_sec ^ seed[0], tv.tv_usec ^ seed[1]);
>  	seeded = 1;
> -	return;
>  }
>  
>  /* NB expects LNET_LOCK held */
> @@ -357,11 +356,10 @@ lnet_add_route(__u32 net, unsigned int hops, lnet_nid_t gateway,
>  
>  		if (rc == -EHOSTUNREACH) { /* gateway is not on a local net */
>  			return 0;	/* ignore the route entry */
> -		} else {
> -			CERROR("Error %d creating route %s %d %s\n", rc,
> -			       libcfs_net2str(net), hops,
> -			       libcfs_nid2str(gateway));
> -		}
> +		CERROR("Error %d creating route %s %d %s\n", rc,
> +		       libcfs_net2str(net), hops,
> +		       libcfs_nid2str(gateway));
> +
>  		return rc;
>  	}
>  

This change broke the build :(

Please always test build your changes, cna you fix it up and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/