linux-kernel - Re: [PATCH] x86, mce, severities: Add AMD severities function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 09:41:01 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>, "Luck, Tony" <tony.luck@...el.com>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"slaoub@...il.com" <slaoub@...il.com>,
	"luto@...capital.net" <luto@...capital.net>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: Re: [PATCH] x86, mce, severities: Add AMD severities function

On 3/19/2015 4:29 AM, Borislav Petkov wrote:
> On Thu, Mar 19, 2015 at 12:01:32AM +0000, Luck, Tony wrote:
>> One other thought.  Instead of the run-time test to see if this is an AMD processor on every call
>> to this function, would it be cleaner to:
>>
>> 1) Rename existing mce_severity() function to mce_severity_intel()
>> 2) Declare a function pointer named mce_severity.
>> 3) Assign that pointer to the _intel() or _amd() function in mce_init()
> Yes, of course. We do that (or at least pretty close) in other paths
> too.
>
>

Ok, I'll work on this and prepend the changes to the current version of 
the patch.
Would you prefer the changes be in a separate patch or lump it in along 
with current version?

Thanks,
-Aravind.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/