linux-kernel - Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150319155553.GK25365@htj.duckdns.org>
Date:	Thu, 19 Mar 2015 11:55:53 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	Olof Johansson <olof@...om.net>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Luis R . Rodriguez" <mcgrof@...e.com>
Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load
 successfully early.

On Thu, Mar 19, 2015 at 04:35:06PM +0100, Borislav Petkov wrote:
> And I don't want to leave the driver loaded when there's nothing to
> be loaded for. One instance in this driver's specific case is one
> northbridge and there are numascale boxes with hundreds of northbridges.
> 
> If you have a better idea about how to unload the driver, asynchronously
> or not, after all probe() calls have failed, I'm all ears.

We don't go around and implement random hacks ignoring layering and
conventions even if that one off case seems to benefit whatever corner
case minutely, because those kind of hacks accumulate and hinder with
improvements at much larger scale and the benefit here is minute.

The driver model has been moving onto separating module load and
probing because that makes far more sense to most drivers that we use
nowadays and also gives userland a cleaner way to manage modules by
separating the two operations - loading and probing.

If you think this is a big enough problem, please go ahead and build
proper infrastructure for it.  Be it a module attribute or even just a
flag telling userland to indicate that the module can be
auto-unloaded.  Sure, it might look like a smart thing from a very
confined viewpoint but you're seeing the problem unfolding right now.
This code is standing in the way of a much more impactful generic
driver layer improvement.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/