linux-kernel - RE: [PATCH RFC] IB/verbs: introduce rdma_transport_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1828884A29C6694DAF28B7E6B8A8237399E821EA@ORSMSX109.amr.corp.intel.com>
Date:	Thu, 19 Mar 2015 17:02:28 +0000
From:	"Hefty, Sean" <sean.hefty@...el.com>
To:	Michael Wang <yun.wang@...fitbricks.com>,
	Roland Dreier <roland@...nel.org>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Or Gerlitz <ogerlitz@...lanox.com>,
	"Weiny, Ira" <ira.weiny@...el.com>,
	Moni Shoua <monis@...lanox.com>,
	"Nikolova, Tatyana E" <tatyana.e.nikolova@...el.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	Yan Burman <yanb@...lanox.com>,
	Jack Morgenstein <jackm@....mellanox.co.il>,
	Bart Van Assche <bvanassche@....org>,
	"Yann Droneaud" <ydroneaud@...eya.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Estrin, Alex" <alex.estrin@...el.com>,
	Doug Ledford <dledford@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Erez Shitrit <erezsh@...lanox.com>,
	Haggai Eran <haggaie@...lanox.com>,
	Sagi Grimberg <sagig@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Eli Cohen <eli@....mellanox.co.il>,
	Matan Barak <matanb@...lanox.com>,
	"Marciniszyn, Mike" <mike.marciniszyn@...el.com>
Subject: RE: [PATCH RFC] IB/verbs: introduce rdma_transport_is_ib() to check
 transport type

> We have plenty of places where we don't care what exactly the
> transport type is, but only care if it's IB type.
> 
> This patch introduce rdma_transport_is_ib() as shortcuts to check
> whether an 'ib_device' is infiniband transport type, which help us to
> save some code.

In most of these places, the check that we want is whether IB management is used.  The transport check is an indirect way of checking for that, and I believe we should use a more direct method of checking for the functionality that's actually desired.

Please see the following thread that is related to these changes:

http://www.spinics.net/lists/linux-rdma/msg23484.html

- Sean