linux-kernel - Re: [PATCH RFC] IB/verbs: introduce rdma_transport_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <550B0780.9040406@profitbricks.com>
Date:	Thu, 19 Mar 2015 18:29:36 +0100
From:	Michael Wang <yun.wang@...fitbricks.com>
To:	"Hefty, Sean" <sean.hefty@...el.com>,
	Roland Dreier <roland@...nel.org>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Or Gerlitz <ogerlitz@...lanox.com>,
	"Weiny, Ira" <ira.weiny@...el.com>,
	Moni Shoua <monis@...lanox.com>,
	"Nikolova, Tatyana E" <tatyana.e.nikolova@...el.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	Yan Burman <yanb@...lanox.com>,
	Jack Morgenstein <jackm@....mellanox.co.il>,
	Bart Van Assche <bvanassche@....org>,
	Yann Droneaud <ydroneaud@...eya.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Estrin, Alex" <alex.estrin@...el.com>,
	Doug Ledford <dledford@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Erez Shitrit <erezsh@...lanox.com>,
	Haggai Eran <haggaie@...lanox.com>,
	Sagi Grimberg <sagig@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Eli Cohen <eli@....mellanox.co.il>,
	Matan Barak <matanb@...lanox.com>,
	"Marciniszyn, Mike" <mike.marciniszyn@...el.com>
Subject: Re: [PATCH RFC] IB/verbs: introduce rdma_transport_is_ib() to check
 transport type

Hi, Sean

Thanks for point it out for me :-)

I'll try to follow the conversation to understand what
really needs to be done, see if I could do some
contribution on it.

Regards,
Michael Wang

On 03/19/2015 06:02 PM, Hefty, Sean wrote:
>> We have plenty of places where we don't care what exactly the
>> transport type is, but only care if it's IB type.
>>
>> This patch introduce rdma_transport_is_ib() as shortcuts to check
>> whether an 'ib_device' is infiniband transport type, which help us to
>> save some code.
> In most of these places, the check that we want is whether IB management is used.  The transport check is an indirect way of checking for that, and I believe we should use a more direct method of checking for the functionality that's actually desired.
>
> Please see the following thread that is related to these changes:
>
> http://www.spinics.net/lists/linux-rdma/msg23484.html
>
> - Sean

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/