linux-kernel - Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550C03D3.7090504@ti.com>
Date:	Fri, 20 Mar 2015 13:26:11 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Liu Ying <Ying.Liu@...escale.com>
CC:	<linux-fbdev@...r.kernel.org>,
	Peter Chen <peter.chen@...escale.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when
 accessing registers

On 11/03/15 05:03, Liu Ying wrote:

>> Why do you check for host->enabled here, but not elsewhere?
> 
> We need this check here to make sure the axi clock reference count is no greater
> than 1.  Looking at the context of mxsfb_set_par(), mxsfb_restore_mode() and

Why is that? The clock framework handles ref counting for you. All the
driver needs to take care of is to call as many times disable as it
calls enable.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)