linux-kernel - Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+8Hj82+qWJxGFSevHwAqTb36DgRQ22OByywbdWjPh4j45Q6yw@mail.gmail.com>
Date:	Fri, 3 Apr 2015 11:39:27 +0800
From:	Liu Ying <liu.y.victor@...il.com>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
Cc:	Liu Ying <Ying.Liu@...escale.com>, linux-fbdev@...r.kernel.org,
	Peter Chen <peter.chen@...escale.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when
 accessing registers

2015-03-20 19:26 GMT+08:00 Tomi Valkeinen <tomi.valkeinen@...com>:
> On 11/03/15 05:03, Liu Ying wrote:
>
>>> Why do you check for host->enabled here, but not elsewhere?
>>
>> We need this check here to make sure the axi clock reference count is no greater
>> than 1.  Looking at the context of mxsfb_set_par(), mxsfb_restore_mode() and
>
> Why is that? The clock framework handles ref counting for you. All the
> driver needs to take care of is to call as many times disable as it
> calls enable.

Okay.  I'll remove the check and send another version.

Regards,
Liu Ying

>
>  Tomi
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/