linux-kernel - Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43330028.130842.1426886180275.open-xchange@webmail.nmp.proximus.be>
Date:	Fri, 20 Mar 2015 22:16:20 +0100 (CET)
From:	Fabian Frederick <fabf@...net.be>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Eric Paris <eparis@...hat.com>, linux-kernel@...r.kernel.org,
	David Howells <dhowells@...hat.com>, Jan Kara <jack@...e.cz>,
	Lino Sanfilippo <LinoSanfilippo@....de>
Subject: Re: [PATCH 1/1 linux-next] fanotify: fix a lock in
 fanotify_should_send_event()



> On 20 March 2015 at 22:09 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
>
> On Fri, 20 Mar 2015 21:56:08 +0100 Fabian Frederick <fabf@...net.be> wrote:
>
> > ltp/fanotify02 was locked since commit 66ba93c0d7fe
> > ("fanotify: don't set FAN_ONDIR implicitly on a marks ignored mask")
>
> What does "ltp/fanotify02 was locked" mean?  That this particular test
> failed to exit, or...?
Hi Andrew,

   It failed to exit, exactly . No information displayed...
Problem appeared in 4.0-rc1.

Regards,
Fabian

>
> > --- a/fs/notify/fanotify/fanotify.c
> > +++ b/fs/notify/fanotify/fanotify.c
> > @@ -140,8 +140,8 @@ static bool fanotify_should_send_event(struct
> > fsnotify_mark *inode_mark,
> >     }
> > 
> >     if (d_is_dir(path->dentry) &&
> > -       !(marks_mask & FS_ISDIR & ~marks_ignored_mask))
> > -           return false;
> > +       (marks_mask & FS_ISDIR & ~marks_ignored_mask))
> > +           return true;
>
> Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/