linux-kernel - Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150320140943.9cca246285c4fa21b7621872@linux-foundation.org>
Date:	Fri, 20 Mar 2015 14:09:43 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>,
	David Howells <dhowells@...hat.com>,
	Lino Sanfilippo <LinoSanfilippo@....de>,
	Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH 1/1 linux-next] fanotify: fix a lock in
 fanotify_should_send_event()

On Fri, 20 Mar 2015 21:56:08 +0100 Fabian Frederick <fabf@...net.be> wrote:

> ltp/fanotify02 was locked since commit 66ba93c0d7fe
> ("fanotify: don't set FAN_ONDIR implicitly on a marks ignored mask")

What does "ltp/fanotify02 was locked" mean?  That this particular test
failed to exit, or...?

> --- a/fs/notify/fanotify/fanotify.c
> +++ b/fs/notify/fanotify/fanotify.c
> @@ -140,8 +140,8 @@ static bool fanotify_should_send_event(struct fsnotify_mark *inode_mark,
>  	}
>  
>  	if (d_is_dir(path->dentry) &&
> -	    !(marks_mask & FS_ISDIR & ~marks_ignored_mask))
> -		return false;
> +	    (marks_mask & FS_ISDIR & ~marks_ignored_mask))
> +		return true;

Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/