linux-kernel - Re: [PATCH v1 04/11] stm class: stm_console: Add kernel-console-over-stm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426939159.15426.4.camel@x220>
Date:	Sat, 21 Mar 2015 12:59:19 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, mathieu.poirier@...aro.org,
	peter.lachner@...el.com, norbert.schulz@...el.com,
	keven.boell@...el.com, yann.fouassier@...el.com,
	laurent.fert@...el.com, Pratik Patel <pratikp@...eaurora.org>
Subject: Re: [PATCH v1 04/11] stm class: stm_console: Add
 kernel-console-over-stm driver

All I spotted is two nits.

On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote:
> +config STM_SOURCE_CONSOLE
> +        tristate "Kernel console over STM devices"

Tab instead of eight spaces, please.

> +	default N

You meant
	default n

as n is a magic symbol. But n is the default anyway, so I think you
might as well drop this line.

> +	help
> +	  This is a kernel space trace source that sends kernel log
> +	  messages to trace hosts over STM devices.
> +
> +	  If you want to send kernel console messages over STM devices,
> +	  say Y.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/