linux-kernel - Re: [PATCH v1 03/11] stm class: dummy_stm: Add dummy driver for testing stm class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426939351.15426.7.camel@x220>
Date:	Sat, 21 Mar 2015 13:02:31 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, mathieu.poirier@...aro.org,
	peter.lachner@...el.com, norbert.schulz@...el.com,
	keven.boell@...el.com, yann.fouassier@...el.com,
	laurent.fert@...el.com, Pratik Patel <pratikp@...eaurora.org>
Subject: Re: [PATCH v1 03/11] stm class: dummy_stm: Add dummy driver for
 testing stm class

All I spotted is the same two nits as in 04/11.

On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote:

> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig

> +config STM_DUMMY
> +        tristate "Dummy STM driver"

Tab instead of eight spaces, please.

> +	default N

You meant
	default n

as n is a magic symbol. But n is the default anyway, so I think you
might as well drop this line.

> +	help
> +	  This is a simple dummy device that pretends to be an stm device
> +	  and discards your data. Use for stm class testing.
> +
> +	  If you don't know what this is, say N.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/