linux-kernel - Re: [PATCH v1 07/11] intel_th: Add Global Trace Hub driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Mar 2015 22:35:50 +0200
From:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	pebolle@...cali.nl, peter.lachner@...el.com,
	norbert.schulz@...el.com, keven.boell@...el.com,
	yann.fouassier@...el.com, laurent.fert@...el.com
Subject: Re: [PATCH v1 07/11] intel_th: Add Global Trace Hub driver

On 20 March 2015 at 19:59, Joe Perches <joe@...ches.com> wrote:
> On Fri, 2015-03-20 at 19:29 +0200, Alexander Shishkin wrote:
>> Global Trace Hub (GTH) is the central component of Intel TH architecture;
>> it carries out switching between the trace sources and trace outputs, can
>> enable/disable tracing, perform STP encoding, internal buffering, control
>> backpressure from outputs to sources and so on.
>
> trivia:

Thank you for reviewing!

>> +     signed char             master[TH_CONFIGURABLE_MASTERS + 1];
>
> why signed?

I'm using -1 to mean "disabled" (0 being a valid port number).

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/